Reviewer Quickstart

A compact checklist for engineers reviewing pull requests in the Keythings Wallet monorepo.

1. Before you review

  • Skim the PR description and linked issues to understand the scope.
  • Open the ADR index at Architecture Decisions and check whether any existing ADRs apply to this area.
  • Confirm the change does not contradict existing ADRs without an explicit update.

2. Baseline checks

Verify that the author has run, and passed, at least:

  • bun run lint
  • bun run build (once for the change set)
  • bun audit

3. Deeper checks for risky changes

For changes that touch keys, RPC surfaces, capability tokens, or storage:

  • Ask the author to run targeted tests (for example, bun run test:unit, bun run test:integration,bun run test:e2e, and bun run security where appropriate).
  • Use Security Overview andTesting & Assurance as checklists for questions to ask.
  • Confirm any new validation paths use Zod schemas rather than try/catch-based checks.

4. Code and docs alignment

  • Ensure new or changed behaviour is reflected in relevant docs pages (architecture, API reference, security).
  • For significant changes, check that a new or updated ADR exists in docs/adr/ and is linked from the PR description.

5. Review outcomes

  • Request changes when behaviour is unclear, untested, or under-documented.
  • Approve when the change is well scoped, tests are in place, linters and builds are clean, and docs/ADRs are updated.
30 of 33